Core: Add REST catalog adapter and tests #4241
Conversation
rdblue
changed the title
| Assert.assertFalse("Namespace should not exist", catalog.namespaceExists(withDot)); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
nit: would it make sense to pull these out into a separate PR so that we get those in sooner? Unless this PR won't take too long to be merged of course
| } | ||
| } | ||
|
|
||
| this.requriedLength = parts.size(); |
| /** | ||
| * Adaptor class to translate REST requests into {@link Catalog} API calls. | ||
| */ | ||
| public class RESTCatalogAdapter implements RESTClient { |
There was a problem hiding this comment.
would it make sense to have a separate test class for this adapter to make sure routing and other stuff is properly tested?
There was a problem hiding this comment.
I don't think so. I'm actually thinking that this class will probably be moved to tests. What we want to make available is CatalogHandlers. The adapter is just a simple way to go between the RESTClient API and CatalogHandlers.
|
|
||
| @Override | ||
| public String toString() { | ||
| return "CharSequenceSet({" + Streams.stream(iterator()).collect(Collectors.joining(", ")) + "})"; |
There was a problem hiding this comment.
Nit, Collectors.joining seems to also take prefix, suffix argument, instead of adding them manually?
rdblue
force-pushed
the
add-rest-catalog-adaptor
branch
from
0d1d4e7 to
339cc16
Compare
rdblue
force-pushed
the
add-rest-catalog-adaptor
branch
from
339cc16 to
ce1b8b9
Compare
3 participants
This adds an implementation of
RESTClientthat translates REST protocol requests to theCatalogAPI. This makes it possible to test theRESTCatalogimplementation like any other catalog. These tests do not exercise serialization; request and response objects are passed between methods directly.RESTCatalogAdaptoris a simple translation fromRESTClientroutes to catalog handlersCatalogHandlersaccepts request objects, makes the appropriate calls to a catalog, and produces response objectsRESTCatalogis aCatalogimplementation that translates to calls toRESTClientTestRESTCatalogrunsCatalogTestsagainst theRESTCatalogThis also implements load table and update table routes, with new tests in
CatalogTeststhat are passing for REST and JDBC.To get tests working, this PR includes a few other changes and fixes:
equalstoCharSequenceSetfor assertionsTableMetadataParserto handlerefs-1to signal "last added" in schema, partition spec, and sort order changesTableMetadatahistory timestamps by detecting whether a snapshot was addedapplyTo(TableMetadata.Builder)toMetadataUpdateto apply changes from the REST protocol on the server side